openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing
Lines 54: Add spaces around = 
Lines 57/58/60/61: 4 character indents please.
Lines 70/75: Remove blank lines
Line 85: missing ;
Line 132: Space after ,

In openlp/plugins/media/lib/mediacontroller.py you need to get rid of any blank lines within the functions, and there should only be one blank line between functions. The same in other modules too.

Again in mediacontroller.py, as it isn't a Qt derived class, all class/local variables and method names should be underscored_like_this, notCamelCased.

Line 788:  if type(display) is types.ListType:
   Separate parameters per type please, rather than have one multi-use parameter which will lead to errors.

There are a number of lines which are greater than 80 characters (ignoring libvlc.py of course). 

A few print statements and commented out code to be removed

-- 
https://code.launchpad.net/~crichter/openlp/media/+merge/58734
Your team OpenLP Core is subscribed to branch lp:openlp.