openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Jonathan Corwin has proposed merging lp:~j-corwin/openlp/present into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #598361 in OpenLP: "AttributeError: 'NoneType' object has no attribute 'isPaused'"
  https://bugs.launchpad.net/openlp/+bug/598361
  Bug #608149 in OpenLP: "Presentations are not intuitive"
  https://bugs.launchpad.net/openlp/+bug/608149
  Bug #769513 in OpenLP: "traceback when going live with impress presentation"
  https://bugs.launchpad.net/openlp/+bug/769513
  Bug #773036 in OpenLP: "Invalid type when opening a powerpoint presentation"
  https://bugs.launchpad.net/openlp/+bug/773036

For more details, see:
https://code.launchpad.net/~j-corwin/openlp/present/+merge/59591

Although preventing users from importing presentations will make supporting it easier, apparently it's not a desirable feature. Remove the "." from the file extension!
-- 
https://code.launchpad.net/~j-corwin/openlp/present/+merge/59591
Your team OpenLP Core is requested to review the proposed merge of lp:~j-corwin/openlp/present into lp:openlp.

=== modified file 'openlp/plugins/presentations/lib/mediaitem.py'
--- openlp/plugins/presentations/lib/mediaitem.py	2011-04-29 22:29:53 +0000
+++ openlp/plugins/presentations/lib/mediaitem.py	2011-04-30 16:15:49 +0000
@@ -293,7 +293,7 @@
         "supports" the extension. If none found, then look for a controller
         which "also supports" it instead.
         """
-        filetype = os.path.splitext(filename)[1]
+        filetype = os.path.splitext(filename)[1][1:]
         if not filetype:
             return None
         for controller in self.controllers: