openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol-hush/openlp/fixes2 into lp:openlp

To: mp+59681@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Mon, 02 May 2011 18:14:00 -0000
In-reply-to: <20110502174106.14997.23596.launchpad@loganberry.canonical.com>
Reply-to: mp+59681@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
I think line 41 needs to be an "if not windows and if not osx" check, rather than an if linux. (FreeBSD etc)

However is the if check needed at all. What happens if you create default_translator regardless of system, and app.installTranslator is given a folder that doesn't exist? Does it crash? (Note I agree the system languages will still need to be part of the install package on Windows/OSX)

Also as it stands currently on Windows/OSX it will do an app.installTranslator on the same path twice.  Is this necessary?
-- 
https://code.launchpad.net/~googol-hush/openlp/fixes2/+merge/59681
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol-hush/openlp/fixes2 into lp:openlp
From: Andreas Preikschat, 2011-05-02