openlp-core team mailing list archive

[jerryb <gerald.britton@xxxxxxxxx>]

On Wed, May 4, 2011 at 4:36 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Looks ok but some comments.
>
> in TranslateContext what does PREFIX + give us.  Should be strings be not "OpenLP.XYZ".
> Blank line between 62 and 63.

You can do that.  I typically don't since I don't like duplicates.
It's also a one-liner if you want to change it to "Bill and Ted's
excellent projection assistant" though I can imagine that one won't
come up :).

Anyway I don't feel strongly about it.  It's just the way I often do things
-- 
https://code.launchpad.net/~gerald-britton/openlp/constants/+merge/59990
Your team OpenLP Core is requested to review the proposed merge of lp:~gerald-britton/openlp/constants into lp:openlp.