openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing
10	+ [instance.__setattr__(key, kwargs[key]) for key in kwargs]

59	+ [self.actions[widget].setVisible(False) for widget in widgets]

... etc.

Is a dangling list a good idea?

Also, using <dict>.iteritems() is a little more efficient (it uses a generator):

    for key, value in kwargs.iteritems():
        instance.__setattr__(key, value)
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/60271
Your team OpenLP Core is subscribed to branch lp:openlp.