openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Hello,

Some languages cannot be chosen (causes a traceback):
- (Afan) Oromo
- Hebrew (former iw)
- Indonesian (former in)
- Yiddish (former ji)

Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 131, in onCurrentIdChanged
    self.performWizard()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 590, in performWizard
    language_id = self.newbibles[number].get_language()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/lib/db.py", line 485, in get_language
    language_id = language[u'id']
TypeError: 'NoneType' object is not subscriptable


When I cancel an import I get this traceback the next time I try to run it (but then it works again):

Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 131, in onCurrentIdChanged
    self.performWizard()
  File "/home/andreas/Projekte/openlp/trunk/openlp/plugins/bibles/forms/bibleupgradeform.py", line 633, in performWizard
    self.newbibles[number].create_verse(db_book.id,
KeyError: 0

You added an image, don't you want to use it?

I am not sure if you we should show the "Upgrade Bible databases" all the time. I guess we should hide this entry when there is not bible to upgrade (you have to upgrade them only once so we don't have to bother people with this entry).

Also I am not quite sure about the combo boxes at the end of the upgrade progress. Do we really need them?

Cheers
-- 
https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/60828
Your team OpenLP Core is subscribed to branch lp:openlp.