openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Hello,

Could you replace 371-379 with something like this:

        if search_results:
            versetext = u' '.join([verse.text for verse in search_results])
            return [string, versetext]
        return []

When I try to search a keyword in a bible I get this traceback (sure, I figured myself that you are not supposed to search keywords, but people will do):

Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/remotes/lib/httpserver.py", line 302, in ready_read
    response = func(*args)
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/remotes/lib/httpserver.py", line 477, in search
    results = media_item.search(text)
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/bibles/lib/mediaitem.py", line 916, in search
    search_results = self.parent.manager.get_verses(bible, string, False)
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/bibles/lib/manager.py", line 268, in get_verses
    if show_message:
NameError: global name 'show_message' is not defined

And change the label "Text:" to "Scripture Reference:" as we use this string in OpenLP as well.

Plugins which are not active are still shown on the remote page. Attempting to perform a search causes a traceback:

Traceback (most recent call last):
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/remotes/lib/httpserver.py", line 302, in ready_read
    response = func(*args)
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/remotes/lib/httpserver.py", line 477, in search
    results = media_item.search(text)
  File "/home/andreas/Projekte/openlp/tmp/openlp/plugins/bibles/lib/mediaitem.py", line 916, in search
    search_results = self.parent.manager.get_verses(bible, string, False)
AttributeError: 'NoneType' object has no attribute 'get_verses'

Is it wanted that a song/bible... is send live when I click one item from the search result list?

Cheers
-- 
https://code.launchpad.net/~j-corwin/openlp/general/+merge/61174
Your team OpenLP Core is subscribed to branch lp:openlp.