openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/custom into lp:openlp

To: mp+61696@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Fri, 20 May 2011 06:12:03 -0000
In-reply-to: <20110520052926.23401.95112.launchpad@loganberry.canonical.com>
Reply-to: mp+61696@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Line 8 looks iffy

onPreviewAddToService will not work as you cannot guarantee the preview and selected items are the same.  The SlideController has the service item so why not call                      self.parent.liveController.addServiceItem(Item)

Line 93 space after comma.
Default value should be None not "*".

setAutoSelectItem should be moved to mediamanageritem 

Just Initialise self.autoSelectItem to none and not bother calling the method then you would not need the default to be set.

-- 
https://code.launchpad.net/~smpettit/openlp/custom/+merge/61696
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~smpettit/openlp/custom into lp:openlp
From: Stevan Pettit, 2011-05-20