openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Hey,

The way we manage shorcuts has changed in the meanwhile. We do not need to translate the "F1", instead we want to change the base_action to a shortcut_action.

-        # Uncomment after 1.9.5 beta string freeze
-        #self.HelpOnlineHelpItem.setShortcut(
-        #    translate('OpenLP.MainWindow', 'F1'))
+        self.HelpOnlineHelpItem.setShortcut(
+            translate('OpenLP.MainWindow', 'F1'))

Isn't your fault, but needs to be changed.
-- 
https://code.launchpad.net/~raoul-snyman/openlp/i18n/+merge/62244
Your team OpenLP Core is subscribed to branch lp:openlp.