openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~milleja46/openlp/milleja46 into lp:openlp

To: mp+62387@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Thu, 26 May 2011 06:32:31 -0000
In-reply-to: <20110526001427.3121.86740.launchpad@loganberry.canonical.com>
Reply-to: mp+62387@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Delete line 45

Line 88, shouldn't be pass, but: 
    row = self.previewListWidget.rowCount() - 1
Otherwise row will be one greater than the highest index in the controller.

Leave the self.parent.generalSettingsSection until Tim has chance to respond to my earlier comment and I find out why he wants it changed. But it still needs splitting so it doesn't go over 80 characters.
-- 
https://code.launchpad.net/~milleja46/openlp/milleja46/+merge/62387
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~milleja46/openlp/milleja46 into lp:openlp
From: Joshua Miller, 2011-05-26