openlp-core team mailing list archive

[jerryb <gerald.britton@xxxxxxxxx>]

On Thu, May 26, 2011 at 11:45 AM, Andreas Preikschat
<andreaspreikschat@xxxxxxxxxx> wrote:
> Review: Needs Fixing
> Hello,
>
> Please remove the lambda. It is rather confusing than helpful (the call has to be made anyway).

That's a rather subjective statement that I can't agree with.  OTOH if
we need multiple error messages (see below) the question is moot.

>And  'Unable to open file' is not the right error message when the file does not exist.

Well, actually we don't know that it doesn't exist.  The
os.path.isfile method can return False when the path exists but is not
a regular file.  We only know that we can't open it.  Of course, we
could add a call to os.stat and catch OSError to know for sure.  Do
you want me to do that?  Then we'd have two conditions:

1. The path exists but is not a regular file
2. The path does not exist

If not, what error messages would you like to see? (Better than my guessing!)

>(Btw, we don't use unicode strings for strings in translate).

OK -- but does it cause a problem?  Do you want the unicode removed?

>
> Sorry...
> --
> https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62484
> You are the owner of lp:~gerald-britton/openlp/newbugs.
>



-- 
Gerald Britton

https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62484
Your team OpenLP Core is subscribed to branch lp:openlp.