← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~gerald-britton/openlp/newbugs into lp:openlp

 

On Thu, May 26, 2011 at 12:42 PM, Tim Bentley <tim.bentley@xxxxxxxxx> wrote:
> Review: Needs Fixing
> translate does not work properly with u'' strings so they need to be removed.
>
> 131 needs some context text.

I just followed other importers for that line. e.g.

openlp/plugins/songs/lib/cclifileimport.py:84:
self.log_error(filename)
openlp/plugins/songs/lib/cclifileimport.py:88:
self.log_error(filename)
openlp/plugins/songs/lib/wowimport.py:114:
self.log_error(file)
openlp/plugins/songs/lib/wowimport.py:154:
self.log_error(file)
openlp/plugins/songs/lib/ewimport.py:268:
self.log_error(self.import_source)
openlp/plugins/songs/lib/songshowplusimport.py:184:
self.log_error(file)
openlp/plugins/songs/lib/opensongimport.py:288:
self.log_error(file.name)
openlp/plugins/songs/lib/songbeamerimport.py:154:
self.log_error(file)
openlp/plugins/songs/lib/olp1import.py:134:
self.log_error(self.import_source)

In any case, at that point, we don't know what went wrong, just that
the import did not work.

> --
> https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62484
> You are the owner of lp:~gerald-britton/openlp/newbugs.
>



-- 
Gerald Britton

https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62484
Your team OpenLP Core is subscribed to branch lp:openlp.


References