← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~j-corwin/openlp/general into lp:openlp

To: mp+62760@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 28 May 2011 16:53:23 -0000
In-reply-to: <20110528101726.12498.71179.launchpad@loganberry.canonical.com>
Reply-to: mp+62760@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
101	+ self.parent = plugin.formparent

Use self.setParent() or instantiate the form properly by passing the parent to the form. The line above removes the Qt methond "parent()" and replaces it with the variable.

Everything else looks fine.
-- 
https://code.launchpad.net/~j-corwin/openlp/general/+merge/62760
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~j-corwin/openlp/general into lp:openlp
From: Jonathan Corwin, 2011-05-28