openlp-core team mailing list archive

[jerryb <gerald.britton@xxxxxxxxx>]

Review: Resubmit
hmmm... You are correct in that the intention is to raise an exception if all attempts to connect with uno fail.  As it stands, it will only allow one failure before raising an exception.  There are two ways to remedy this:

1. add an undented "else:" before the raise in line 73, which causes it to be executed only if the loop falls through.  
2. undent the raise itself.  

I often like the first approach although I find not all pythonistas like that form or use it.  (Even Guido has his doubts about it).  Still it is useful when you want to be clear that the suite only executes if the loop falls through, not if the loop contains a "break" for instance.  In this case though there is nothing after the loop in the function so the distinction is not as meaningful.  So, I chose the second approach.

About the other thing, I need to understand the need to resubmit when (as in this case) the merge does not affect the modules being patched.  Also, is it enough to choose "Resubmit" from the drop-down beside the "Review:" label underneath the comment space or should I use the link at the top of the page?
-- 
https://code.launchpad.net/~gerald-britton/openlp/newbugs/+merge/62921
Your team OpenLP Core is subscribed to branch lp:openlp.