← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

 

> I'm going to show my ignorance and ask what is the difference between 204 &
> 205/206?
I am not absolutely sure myself, but Raoul once reviewed on of my proposal with "Needs fixing" (doing that was I am now reverting):
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/60278

Anyway, list comprehension is actually not want we want here as it creates a list but we do not want a list (with None, None, None, None, ...). And it seems to be slower in this case as well (probably because we are creating the list).
-- 
https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/63075
Your team OpenLP Core is subscribed to branch lp:openlp.


References