← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bug_788231 into lp:openlp

To: mp+63589@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Tue, 07 Jun 2011 04:34:22 -0000
In-reply-to: <20110606174117.15152.93878.launchpad@loganberry.canonical.com>
Reply-to: mp+63589@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Information
Hello,

Why the -1 in line 27? In my tests this makes the results rather inaccurate. I tested 30px-74px (certainly not all sizes, but I checked the line count predictions and they were all smaller than the actual line count).
-- 
https://code.launchpad.net/~trb143/openlp/bug_788231/+merge/63589
Your team OpenLP Core is subscribed to branch lp:openlp.

Follow ups

Re: [Merge] lp:~trb143/openlp/bug_788231 into lp:openlp
From: Tim Bentley, 2011-06-07

References

[Merge] lp:~trb143/openlp/bug_788231 into lp:openlp
From: Tim Bentley, 2011-06-06