openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing
_clean_cache() should be _process_cache()  - clean implies empty in one operation not do work.

I can see your logic but there seems to be a lot of moving priorities. 
If I add an Image to Live it gets:
Added to queue as normal
processed to correct size.
Moved to low
more then likely if is requested in get_bytes
Move to High
processed
returned by function call.

This seems a lot of messing around when just processing with resize and convert should be faster! 
-- 
https://code.launchpad.net/~googol-hush/openlp/image-queue/+merge/65875
Your team OpenLP Core is subscribed to branch lp:openlp.