openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/windows-help into lp:openlp

To: mp+65976@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Mon, 27 Jun 2011 14:52:41 -0000
In-reply-to: <20110627131121.17496.69752.launchpad@loganberry.canonical.com>
Reply-to: mp+65976@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
If we were to do it on other platforms, I'm guessing it would be unlikely for it to be a .chm file as this is a Microsoft format file. So I think an operating system check here would be good to avoid an unnecessary file system lookup.

Would it be possible to change the windows build to create the file as "OpenLP.chm" and change the corresponding casing here too on line 10?
-- 
https://code.launchpad.net/~smpettit/openlp/windows-help/+merge/65976
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~smpettit/openlp/windows-help into lp:openlp
From: Stevan Pettit, 2011-06-27