← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~karan85/openlp/ewimport-fix into lp:openlp

 

Some of us use less or grep in a terminal, and in those instances 80 characters helps. Also the diff we get when you submit code changes is easier to read when it wraps at 80 characters.

Documentation examples are not a good place to use for examples of variable names, since they are examples rather than real code. 

Over time code might start to separate, so although you may now have:
  p = get_something()
  do_something_with(p)

in a years time it might turn into
  p = get_something()
  ...
  50 lines of other stuff
  ...
  do_something_with(p)

Now it is no longer obvious what p is, and things are more likely to break if someone else decides to inadvertantly create a new p in the 50 new lines of code.

-- 
https://code.launchpad.net/~karan85/openlp/ewimport-fix/+merge/66842
Your team OpenLP Core is subscribed to branch lp:openlp.


References