openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/ftw into lp:openlp

To: mp+68849@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Fri, 22 Jul 2011 17:21:37 -0000
In-reply-to: <20110722141812.22123.35249.launchpad@loganberry.canonical.com>
Reply-to: mp+68849@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
If we're going to restart OpenLP then it needs to be an OK/Cancel rather than just an OK. 
Does the exec of the sys.executable work on all platforms?
"OpenLP_exe" does not conform to variable names, but not sure why we need that variable anyway.

Personally I'd prefer the wizard to run whilst OpenLP was still running, or just offer the functionality that is in the wizard that isn't already in OpenLP. I.e. add options to import the sample data to the existing File -> Import options.
-- 
https://code.launchpad.net/~smpettit/openlp/ftw/+merge/68849
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~smpettit/openlp/ftw into lp:openlp
From: Stevan Pettit, 2011-07-22