openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Line 57/76: Either "Run First Time Wizard" or "Re-Run First Time Wizard"
Line 75: Please change the varialbe "ret" to something more readable. Best might be "answer"
Line 76: Not sure if we allow question marks in the dialog title. Also the string should be checked by superfly.
Line 78-80: You do not need the "+ \"
Line 86/87: I suggest to change to

if answer == QtGui.QMessageBox.No:
    retrun

This saves you 4 spaces in the following code (line 87-104).

Line 100: Long line (see comment above).

-- 
https://code.launchpad.net/~smpettit/openlp/ftw/+merge/68968
Your team OpenLP Core is subscribed to branch lp:openlp.