← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/ftw into lp:openlp

To: mp+70159@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Wed, 03 Aug 2011 06:14:28 -0000
In-reply-to: <20110802131133.777.44191.launchpad@loganberry.canonical.com>
Reply-to: mp+70159@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing
Line 8: The comment is too long. But you can simply omit the second sentence, because you already mention this in line 12.
Line 12: Missing full stop.
Line 13: You do not have to make the theme_list an instance variable.
-- 
https://code.launchpad.net/~smpettit/openlp/ftw/+merge/70159
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~smpettit/openlp/ftw into lp:openlp
From: Stevan Pettit, 2011-08-02