openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
lines 58-72: Sorry, it was not you who added this code, but it should be removed.
lines 48-49: Better use "answer" instead of "ans". Avoid abbreviations where possible.

I added a few images to the service (one service item). Then I renamed the folder (to simulate e. g. un-pluggin a flash drive with images on). Then I tried to save the service.

1)
The dialog asks me whether I want to continue or not. If I say "No" the next dialog opens and asks the same thing.
Why not do this:
if answer == QtGui.QMessageBox.No:
    self.mainwindow.finishedProgressBar()
    Receiver.send_message(u'cursor_normal')
    return False

2)
If I say "Yes" the same thing happens, namely another dialog opens. This should be straightened (if possible).

Talk to me in IRC if you have any questions.
-- 
https://code.launchpad.net/~smpettit/openlp/save_service/+merge/70438
Your team OpenLP Core is subscribed to branch lp:openlp.