openlp-core team mailing list archive

[Stevan Pettit <smpettit@xxxxxxxxxxxxxxx>]

Stevan Pettit has proposed merging lp:~smpettit/openlp/service_reorder into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~smpettit/openlp/service_reorder/+merge/70637

Bug #818791 

Modified serviceitemeditform to remove/move item in list based on selected index number, not by first match of item text

.remove - Remove the first item from the list whose value is x.
.pop    - Remove the item at the given position in the list
-- 
https://code.launchpad.net/~smpettit/openlp/service_reorder/+merge/70637
Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/service_reorder into lp:openlp.

=== modified file 'openlp/core/ui/serviceitemeditform.py'
--- openlp/core/ui/serviceitemeditform.py	2011-06-12 16:02:52 +0000
+++ openlp/core/ui/serviceitemeditform.py	2011-08-05 22:53:25 +0000
@@ -79,7 +79,7 @@
         if not item:
             return
         row = self.listWidget.row(item)
-        self.itemList.remove(self.itemList[row])
+        self.itemList.pop(row)
         self.loadData()
         if row == self.listWidget.count():
             self.listWidget.setCurrentRow(row - 1)
@@ -109,7 +109,7 @@
             return
         row = self.listWidget.row(item)
         temp = self.itemList[row]
-        self.itemList.remove(self.itemList[row])
+        self.itemList.pop(row)
         if direction == u'up':
             row -= 1
         else: