openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Andreas Preikschat has proposed merging lp:~googol/openlp/OpenLyrics into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~googol/openlp/OpenLyrics/+merge/71475

Hello,

The song meta data (createdIn, modifiedIn) in OpenLyrics files have to contain the application name and the version number.

<?xml version='1.0' encoding='utf-8'?>
<song xmlns="http://openlyrics.info/namespace/2009/song"; version="0.7" createdIn="OpenLP 1.9.6" modifiedIn="OpenLP 1.9.6" modifiedDate="2011-08-14T12:44:23">

instead of

<?xml version='1.0' encoding='utf-8'?>
<song xmlns="http://openlyrics.info/namespace/2009/song"; version="0.7" createdIn="1.9.6" modifiedIn="1.9.6" modifiedDate="2011-08-14T12:44:23">

http://openlyrics.info/dataformat.html#required-data-items
-- 
https://code.launchpad.net/~googol/openlp/OpenLyrics/+merge/71475
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/OpenLyrics into lp:openlp.

=== modified file 'openlp/plugins/songs/lib/xml.py'
--- openlp/plugins/songs/lib/xml.py	2011-07-13 13:32:19 +0000
+++ openlp/plugins/songs/lib/xml.py	2011-08-14 11:03:24 +0000
@@ -246,8 +246,9 @@
         # Append the necessary meta data to the song.
         song_xml.set(u'xmlns', u'http://openlyrics.info/namespace/2009/song')
         song_xml.set(u'version', OpenLyrics.IMPLEMENTED_VERSION)
-        song_xml.set(u'createdIn', get_application_version()[u'version'])
-        song_xml.set(u'modifiedIn', get_application_version()[u'version'])
+        application_name = u'OpenLP ' + get_application_version()[u'version']
+        song_xml.set(u'createdIn', application_name)
+        song_xml.set(u'modifiedIn', application_name)
         song_xml.set(u'modifiedDate',
             datetime.datetime.now().strftime(u'%Y-%m-%dT%H:%M:%S'))
         properties = etree.SubElement(song_xml, u'properties')