openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

63	+ self._conversion_queue = PriorityQueue()

In your "update_images" and "update_image" methods, you have this line. What happens then is that every time you call either of those two methods you create a *new* object. This is great the first time when you don't have an object, but every subsequent time you get another new object.

Python's garbage collector usually runs *after* your application is finished. This means that you're going to be increasing OpenLP's memory footprint every time you run one of those methods.

The better way to implement this would be to simply check if the object is None and then create the object. The other times you can just clear the list.
-- 
https://code.launchpad.net/~trb143/openlp/features4/+merge/72324
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/features4 into lp:openlp.