openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing
Line 143 and 410: No \ needed.
Line 455/456: The operator should be before the \
if bla and \
    foo:

instead of

if bla \
    and foo:

When I hide the display (Hide Screen) and send a video live, the diplay is shown. But it should not be shown. (Single monitor set up)

Line 468: You can remove "shrinkItem" and use "self" instead.
Line 744/754: We have two blank lines between classes.
Line 958: Don't use a new line for each sentence, instead add full stops after each one and wrap the sentence if necessary. Also the syntax is not correct (the enumeration with "-" will not work). I suggest this: http://rst.ninjs.org/?n=9abe8c216bafbd786601f2ef62a9d8a8&theme=basic
Line 981 (and following): self.Time should be self.time
-- 
https://code.launchpad.net/~crichter/openlp/media_rewrite/+merge/73416
Your team OpenLP Core is subscribed to branch lp:openlp.