← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~smpettit/openlp/ftw-no-internet.net into lp:openlp

To: mp+75229@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Wed, 14 Sep 2011 20:10:24 -0000
In-reply-to: <20110913173226.8208.21027.launchpad@ackee.canonical.com>
Reply-to: mp+75229@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Line 9: Do not put two imports on one line. http://wiki.openlp.org/Development:Coding_Standards#Imports

Line 147 ff: Do not change any strings, as we have string freeze.
-- 
https://code.launchpad.net/~smpettit/openlp/ftw-no-internet.net/+merge/75229
Your team OpenLP Core is subscribed to branch lp:openlp.

Follow ups

Re: [Merge] lp:~smpettit/openlp/ftw-no-internet.net into lp:openlp
From: Andreas Preikschat, 2011-09-15

References

[Merge] lp:~smpettit/openlp/ftw-no-internet.net into lp:openlp
From: Stevan Pettit, 2011-09-13