openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bugs-814201 into lp:openlp

To: mp+77832@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Mon, 03 Oct 2011 00:31:08 -0000
In-reply-to: <20111002200623.4714.38088.launchpad@ackee.canonical.com>
Reply-to: mp+77832@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

- The new dialog does not work here. I changed the comboboxes' values but the preview did not change. - Also check your docstrings/comments; full sentences should start capitalized and end with a period.
- The prefix "hr" is not very common, at least I have not seen it. I think "h" is the better prefix here (http://www.bipm.org/en/si/si_brochure/chapter4/table6.html).
-- 
https://code.launchpad.net/~trb143/openlp/bugs-814201/+merge/77832
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/bugs-814201 into lp:openlp
From: Tim Bentley, 2011-10-02