openlp-core team mailing list archive

[Stevan Pettit <openlp@xxxxxxxxxxxxxxx>]

> Can you not use a single psvince.dll file, and a single set of functions
> everywhere? Do you have to duplicate everything?

I tried that.

During the install, the dll is unpacked to a temp dir then used before anything (such as an app dir) is created on the users machine.

The dll is then copied to the app dir during the actual installation.  During uninstall, the dll is loaded from the app dir.  The dll ultimately only exists once.

The 2 function definitions are needed to load the dll from 2 entirely different places even though their function is identical.  The dll is only loaded when needed.

The check function could possible be written to use some form of "if" statement to determine if it's being called by an install or uninstall but I'm not sure if that would make much of a difference.  The message is slightly different.  I feel the 2 functions look "cleaner"....  Do this during install..... do this during uninstall.  We could possible (at tome later date)in the uninstall, give an option to remove all data as well.

-- 
https://code.launchpad.net/~smpettit/openlp/inno-uninstall/+merge/79121
Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/inno-uninstall into lp:openlp.