openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Andreas Preikschat has proposed merging lp:~googol/openlp/bug-871272 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #871272 in OpenLP: "When slides are in the foreground openlp reports "Error: No display item to ammend" in latest build"
  https://bugs.launchpad.net/openlp/+bug/871272

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-871272/+merge/79469

Hello,

1) Fixed bug 871272 (When slides are in the foreground openlp reports 'Error: No display item to ammend' in latest build)
2) Docstrings
-- 
https://code.launchpad.net/~googol/openlp/bug-871272/+merge/79469
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-871272 into lp:openlp.

=== modified file 'openlp/core/lib/serviceitem.py'
--- openlp/core/lib/serviceitem.py	2011-10-03 16:53:54 +0000
+++ openlp/core/lib/serviceitem.py	2011-10-15 11:41:23 +0000
@@ -122,9 +122,8 @@
 
     def _new_item(self):
         """
-        Method to set the internal id of the item
-        This is used to compare service items to see if they are
-        the same
+        Method to set the internal id of the item. This is used to compare
+        service items to see if they are the same.
         """
         self._uuid = unicode(uuid.uuid1())
 
@@ -160,9 +159,8 @@
     def render(self, use_override=False):
         """
         The render method is what generates the frames for the screen and
-        obtains the display information from the renderemanager.
-        At this point all the slides are built for the given
-        display size.
+        obtains the display information from the renderemanager. At this point
+        all the slides are built for the given display size.
         """
         log.debug(u'Render called')
         self._display_frames = []

=== modified file 'openlp/core/ui/maindisplay.py'
--- openlp/core/ui/maindisplay.py	2011-10-03 17:27:34 +0000
+++ openlp/core/ui/maindisplay.py	2011-10-15 11:41:23 +0000
@@ -355,7 +355,7 @@
         """
         # We request a background video but have no service Item
         if isBackground and not hasattr(self, u'serviceItem'):
-            return None
+            return False
         if not self.mediaObject:
             self.createMediaObject()
         log.debug(u'video')
@@ -385,6 +385,7 @@
         # Update the preview frame.
         if self.isLive:
             Receiver.send_message(u'maindisplay_active')
+        return True
 
     def videoState(self, newState, oldState):
         """

=== modified file 'openlp/plugins/media/lib/mediaitem.py'
--- openlp/plugins/media/lib/mediaitem.py	2011-09-06 17:53:43 +0000
+++ openlp/plugins/media/lib/mediaitem.py	2011-10-15 11:41:23 +0000
@@ -39,7 +39,7 @@
 
 log = logging.getLogger(__name__)
 
-CLAPPERBOARD = QtGui.QPixmap(u':/media/media_video.png').toImage()
+CLAPPERBOARD = QtGui.QImage(u':/media/media_video.png')
 
 class MediaMediaItem(MediaManagerItem):
     """
@@ -95,14 +95,14 @@
 
     def onResetClick(self):
         """
-        Called to reset the Live backgound with the media selected,
+        Called to reset the Live backgound with the media selected.
         """
         self.resetAction.setVisible(False)
         self.plugin.liveController.display.resetVideo()
 
     def videobackgroundReplaced(self):
         """
-        Triggered by main display on change of serviceitem
+        Triggered by main display on change of serviceitem.
         """
         self.resetAction.setVisible(False)
 
@@ -179,8 +179,7 @@
 
     def mediaStateWait(self, mediaState):
         """
-        Wait for the video to change its state
-        Wait no longer than 5 seconds.
+        Wait for the video to change its state. Wait no longer than 5 seconds.
         """
         start = datetime.now()
         while self.mediaObject.state() != mediaState:
@@ -198,7 +197,7 @@
 
     def onDeleteClick(self):
         """
-        Remove a media item from the list
+        Remove a media item from the list.
         """
         if check_item_selected(self.listView, translate('MediaPlugin.MediaItem',
             'You must select a media file to delete.')):