openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

The proposal to merge lp:~googol/openlp/bug-871441 into lp:openlp has been updated.

Description changed to:

Hello,

1) Fixed bug 871441 (Live Preview image is not updated when you "Replace live background")
The fix is in lines 8+9 and 87-89. I am not absolutely sure about line 9. (I do not want to introduce bug 799549 again.) However, could not recreate the bug myself, thus I cannot say whether my change introduces it again. Anyway, I expect that overwriting the parent() method should not introduce it, rather the initialisation makes the difference (see the merge proposal for the bug mentioned above: https://code.launchpad.net/~j-corwin/openlp/bug-799549/+merge/65259).

2) Removed dead code (lines 17-24)
3) Fixed docstrings
4) Only send the "maindisplay_active" signal when the main display is made active (I do not know if that applies to you as well, but I was always confused by this signal or at least I never felt that this signal were self-explanatory. That is why I removed/replaced it (I missed to remove it in another proposal); not the slide controllers take care or updating themselves.
However, the solution I prefer is, that we emit a signal (e. g. maindisplay_changed). But it should not be emitted on a case by case basis (e. g. in the text, alert, ... methods), rather by generic events (e. g. in the isWebLoaded method). But the problem is, that we also have to emit the signal when we evaluate Java Script.

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-871441/+merge/79496
-- 
https://code.launchpad.net/~googol/openlp/bug-871441/+merge/79496
Your team OpenLP Core is subscribed to branch lp:openlp.