openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #12439
Re: [Merge] lp:~crichter/openlp/media_rewrite into lp:openlp
Review: Needs Fixing
Missing and incomplete comments
; at the end of a number of lines.
Need to respin after my changes go in as they will be changes.
webkitapi.py has constants which should be in CAPITALS.
Check formatting (double blank lines) and field names there are naming standard errors.
Lots of commented out code some of which is your machine specific!
--
https://code.launchpad.net/~crichter/openlp/media_rewrite/+merge/79646
Your team OpenLP Core is subscribed to branch lp:openlp.
References