← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/bug-827862 into lp:openlp

To: mp+80783@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Mon, 31 Oct 2011 18:19:23 -0000
In-reply-to: <20111031091822.7642.16351.launchpad@ackee.canonical.com>
Reply-to: mp+80783@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Being unavailable will not stop imports it just switches them off so there would be no breakage.
I do not like imports in the the middle of code.
It would be better to move the verse case to core.
-- 
https://code.launchpad.net/~googol/openlp/bug-827862/+merge/80783
Your team OpenLP Core is subscribed to branch lp:openlp.

Follow ups

Re: [Merge] lp:~googol/openlp/bug-827862 into lp:openlp
From: Andreas Preikschat, 2011-11-01

References

[Merge] lp:~googol/openlp/bug-827862 into lp:openlp
From: Andreas Preikschat, 2011-10-31