openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Andreas Preikschat has proposed merging lp:~googol/openlp/bug-884826 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #884826 in OpenLP: "Cloning songs does not work"
  https://bugs.launchpad.net/openlp/+bug/884826

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-884826/+merge/80944

- fixed bug #884826 (Cloning songs does not work)
-- 
https://code.launchpad.net/~googol/openlp/bug-884826/+merge/80944
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-884826 into lp:openlp.

=== modified file 'openlp/plugins/songs/lib/mediaitem.py'
--- openlp/plugins/songs/lib/mediaitem.py	2011-10-03 20:28:17 +0000
+++ openlp/plugins/songs/lib/mediaitem.py	2011-11-01 19:29:24 +0000
@@ -419,8 +419,7 @@
             item_id = (self.editItem.data(QtCore.Qt.UserRole)).toInt()[0]
             old_song = self.plugin.manager.get_object(Song, item_id)
             song_xml = self.openLyrics.song_to_xml(old_song)
-            new_song_id = self.openLyrics.xml_to_song(song_xml)
-            new_song = self.plugin.manager.get_object(Song, new_song_id)
+            new_song = self.openLyrics.xml_to_song(song_xml)
             new_song.title = u'%s <%s>' % (new_song.title,
                 translate('SongsPlugin.MediaItem', 'copy',
                 'For song cloning'))