openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

  if u'theme_overwritten' in header:
      self.theme_overwritten = header[u'theme_overwritten']

You could have written:
  self.theme_overwritten = header.get(u'theme_overwritten', False)

Why write:
  self.theme_overwritten = False if theme == None else True

When you can write:
  self.theme_overwritten = (theme == None)
-- 
https://code.launchpad.net/~trb143/openlp/bug-themes/+merge/81354
Your team OpenLP Core is subscribed to branch lp:openlp.