← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~googol/openlp/trivial into lp:openlp

 

Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~googol/openlp/trivial/+merge/82772

- do not (re)load the list twice when cloning a theme

The list is already (re)loaded when we save the new theme. http://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/openlp/core/ui/thememanager.py#L615
-- 
https://code.launchpad.net/~googol/openlp/trivial/+merge/82772
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/trivial into lp:openlp.
=== modified file 'openlp/core/ui/thememanager.py'
--- openlp/core/ui/thememanager.py	2011-11-18 19:34:04 +0000
+++ openlp/core/ui/thememanager.py	2011-11-19 12:10:30 +0000
@@ -300,7 +300,6 @@
             if self.checkIfThemeExists(newThemeName):
                 themeData = self.getThemeData(oldThemeName)
                 self.cloneThemeData(themeData, newThemeName)
-                self.loadThemes()
 
     def cloneThemeData(self, themeData, newThemeName):
         """


Follow ups