openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Andreas Preikschat has proposed merging lp:~googol/openlp/bug-887313 into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #887313 in OpenLP: "Song Usage records printed songs when it should not"
  https://bugs.launchpad.net/openlp/+bug/887313

For more details, see:
https://code.launchpad.net/~googol/openlp/bug-887313/+merge/84378

Hello,

fixed bug 887313 (Song Usage records printed songs when it should not)
-- 
https://code.launchpad.net/~googol/openlp/bug-887313/+merge/84378
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/bug-887313 into lp:openlp.

=== modified file 'openlp/core/ui/printserviceform.py'
--- openlp/core/ui/printserviceform.py	2011-08-26 10:21:47 +0000
+++ openlp/core/ui/printserviceform.py	2011-12-03 18:04:29 +0000
@@ -402,6 +402,9 @@
         settings.endGroup()
 
     def update_song_usage(self):
+        # Only continue when we include the song's text.
+        if not self.slideTextCheckBox.isChecked():
+            return
         for index, item in enumerate(self.serviceManager.serviceItems):
             # Trigger Audit requests
             Receiver.send_message(u'print_service_started',