← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/bug-900399 into lp:openlp

To: mp+84842@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Wed, 07 Dec 2011 21:30:23 -0000
In-reply-to: <20111207205544.1285.3781.launchpad@ackee.canonical.com>
Reply-to: mp+84842@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

131 is an incorrect removal as when a plugin is disabled the settings dialog will fail as the value ins not defined.
Renaming fields is also iffy in a feature freeze.  They are not a bug.
Code simplification is just Ok.
-- 
https://code.launchpad.net/~googol/openlp/bug-900399/+merge/84842
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol/openlp/bug-900399 into lp:openlp
From: Andreas Preikschat, 2011-12-07