openlp-core team mailing list archive

[Meinert Jordan <meinertjordan@xxxxxxxxxx>]

Good point, to transfer v1.x code into a seperate method.

About the file_is_unicode() method: In the used case the function does not make more then calling decode() and log a caught the excepting. Then it needs an additional check and and error dialog on the callers side.
IMHO it makes the code more opaque and has hardly any advantages. For bug fixing one decode() call is hardly an issue. From this point of view one would try outsourcing of all the zip file extraction code. What I'm duplicating is basically one log.exception() call.  
Beside this file_is_unicode() name and comment are completely misleading (which could be fixed of cause).
-- 
https://code.launchpad.net/~m2j/openlp/work/+merge/85413
Your team OpenLP Core is subscribed to branch lp:openlp.