openlp-core team mailing list archive

[mahfiaz <mahfiaz@xxxxxxxxx>]

We could (don't you think these options are exclusive :) ):
* Amuse the user with error messages (error message would break string freeze, so it could be past 1.9.8).
* Drop the unmatched pair, but it seems a little unfair to the users since they probably did add the tag by hand.
* Add the matching pair by ourselves:
a) to the start or end of line
b) to the start or end of verse (or this only if the existing part of pair is at start or end of verse)

Can we require that any formatting tag begins and ends in the same
verse, so no verse lapping is possible? Or is there already support for
such tags?

So what shall we do?

-- 
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/885874

Title:
  Song with mis matched formatting tags amends on render

Status in OpenLP - Worship Presentation Software:
  New

Bug description:
  Create a song and have an opening tag only.
  Save then add to preview.

  BANG

  
  Traceback (most recent call last):
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.plugins.songs.lib.mediaitem", line 374, in onEditClick
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.plugins.songs.lib.mediaitem", line 258, in onSongListLoad
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.core.lib.mediamanageritem", line 623, in buildServiceItem
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.plugins.songs.lib.mediaitem", line 509, in generateSlideData
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.plugins.songs.lib.xml", line 341, in song_to_xml
    File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz/openlp.plugins.songs.lib.xml", line 450, in _add_text_with_tags_to_lines
    File "lxml.etree.pyx", line 2512, in lxml.etree.XML (src/lxml/lxml.etree.c:48057)
    File "parser.pxi", line 1545, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:71812)
    File "parser.pxi", line 1417, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:70608)
    File "parser.pxi", line 898, in lxml.etree._BaseParser._parseUnicodeDoc (src/lxml/lxml.etree.c:67148)
    File "parser.pxi", line 539, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:63824)
    File "parser.pxi", line 625, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:64745)
    File "parser.pxi", line 565, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:64088)
  XMLSyntaxError: Opening and ending tag mismatch: tag line 1 and lines, line 1, column 368

To manage notifications about this bug go to:
https://bugs.launchpad.net/openlp/+bug/885874/+subscriptions