← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/bug-850254 into lp:openlp

To: mp+85728@xxxxxxxxxxxxxxxxxx
From: Jonathan Corwin <j@xxxxxxxxxxxx>
Date: Wed, 14 Dec 2011 19:25:37 -0000
In-reply-to: <20111214191423.22935.75259.launchpad@ackee.canonical.com>
Reply-to: mp+85728@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Too many blank lines 56-58
There is an elif on 53 but an if on 55.

I'm not sure about the term "status" in httpserver, it doesn't seem descriptive enough to me, as lots of things could have a status. Perhaps displaystatus or something?
-- 
https://code.launchpad.net/~trb143/openlp/bug-850254/+merge/85728
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/bug-850254 into lp:openlp
From: Tim Bentley, 2011-12-14