← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mahfiaz/openlp/bug-304 into lp:openlp

To: mahfiaz <mahfiaz@xxxxxxxxx>
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Thu, 15 Dec 2011 08:36:24 -0000
In-reply-to: <20111215035623.31705.7300.launchpad@ackee.canonical.com>
Reply-to: mp+85787@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

1) It should be
except (etree.XMLSyntaxError, AttributeError):

2) Do not do this. This is too dangerous.... Any AttributeError in xml_to_song will be caught. Better make sure that the exception is caught in xml_to_song instead.
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/85787
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mahfiaz/openlp/bug-304 into lp:openlp
From: mahfiaz, 2011-12-15