← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~mahfiaz/openlp/bug-860876 into lp:openlp

 

raoul:
> whereas urllib, while part of Python, is not in memory yet. Therefore, importing urllib will actually increase OpenLP's memory footprint.
No. It actually is in the memory, as it is imported for example in openlp.core.lib.db or in openlp.core.utils (via urllib2) and will be shared.
> QByteArray contain a __unicode__ method
No. Refere to riverbanks documentation; there is only a __str__ method
> The object knows what encoding it is in
No. How can it do so? QByteArray is the Qt version of Pythons str. The decoding is done in line 11 (just spotted the wrong utf-8 string). This has to be done also when using urllib.
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-860876/+merge/85758
Your team OpenLP Core is subscribed to branch lp:openlp.


References