openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

This looks like a good start, but here are couple of things that need to
be fixed up:

1. GUI object names:
   Currently your GUI object names use PascalCase, but they should use
   camelCase.

   self.SlideGroupBox => self.slideGroupBox

2. Indentation is incorrect:
   In the diff below you have some indentations which are not 4 spaces.
   - Lines 202 to 213
   - Lines 248 to 258
   - Lines 269 to 279
-- 
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88601
Your team OpenLP Core is subscribed to branch lp:openlp.