openlp-core team mailing list archive

[Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

262 + if QtCore.QSettings().value(
263 +     self.parent().generalSettingsSection + u'/slide advance',
264 +     QtCore.QVariant(SlideAdvance.End)).toInt()[0] \
265 +     == SlideAdvance.Wrap:
266       row = self.previewListWidget.rowCount() - 1
267 + elif QtCore.QSettings().value(
268 +     self.parent().generalSettingsSection + u'/slide advance',
269 +     QtCore.QVariant(SlideAdvance.End)).toInt()[0] \
270 +     == SlideAdvance.Next:
271 +     self.servicePrevious()
272 +     return

Rather than reading the setting twice, read it once beforehand...

slide_advance = QtCore.QSettings().value(
    self.parent().generalSettingsSection + u'/slide advance',
    QtCore.QVariant(SlideAdvance.End)).toInt()[0]
if slide_advance == SlideAdvance.Wrap:
    row = self.previewListWidget.rowCount() - 1
elif slide_advance == SlideAdvance.Next:
    self.servicePrevious()
    return

Also, please just revert all the language files. I'd rather add them in a separate commit.
-- 
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/88606
Your team OpenLP Core is subscribed to branch lp:openlp.