openlp-core team mailing list archive

[Meinert Jordan <meinertjordan@xxxxxxxxxx>]

The cost of calling it four times is really narrow.

While looking to this I asked myself, why you are using self.service_day.
You could use unicode(self.defaultServiceName.text()) each time. Then you could call self.updateServiceNameExample on the slot and save several lines of code. This two strings are anyhow caped in use sync. At least I would like to see a unicode cast before assigning QString to this variable. This way the variable is always Python unicode and there are less possibilities of conversion errors (we handle it this way where ever possible).

Same for self.service_hour and most probably others (have not verified).

Line 161, 163, 165: If you don't use the value of ok, than do not assign it. Just take the first value of the methods return: intval = QVariant().toInt()[0]
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/90613
Your team OpenLP Core is subscribed to branch lp:openlp.