← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

To: mahfiaz <mahfiaz@xxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Mon, 30 Jan 2012 07:56:25 -0000
In-reply-to: <20120129232031.22676.26808.launchpad@ackee.canonical.com>
Reply-to: mp+90629@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Camel police time.
There are inconsistencies in the class now.

Python  classes allow service_name structures
QT based classes need serviceName

This is a QT based class so needs fixing.  lines 15 and 16 are inconsistent.
-- 
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/90629
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp
From: mahfiaz, 2012-01-29