openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~m2j/openlp/cleanups into lp:openlp

To: mp+94692@xxxxxxxxxxxxxxxxxx
From: Raoul Snyman <raoul.snyman@xxxxxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 27 Feb 2012 16:58:43 -0000
In-reply-to: <20120226213023.2314.21412.launchpad@ackee.canonical.com>
Reply-to: mp+94692@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I would suggest using **kwargs instead of a whole bunch of named parameters which might only get longer. It makes the method forward and backward compatible.

Eventually it would be great to replace all the action creation methods with the single kwarg'd version, but we can get to that at a later stage (it isn't a new feature, it's refactoring, so we can still do it up till the merge proposal freeze).
-- 
https://code.launchpad.net/~m2j/openlp/cleanups/+merge/94692
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~m2j/openlp/cleanups into lp:openlp
From: Meinert Jordan, 2012-02-26