openlp-core team mailing list archive

[Jonathan Corwin <j@xxxxxxxxxxxx>]

Review: Needs Fixing

When you make changes/fixes, please could you then resubmit your proposal, using the "Resubmit proposal" link on the merge proposal page. Thanks!

However regarding your change, it is possible to provide a default value as a second argument to QSettings.value(), so instead of checking db_encoding afterwards, you can use
 settings.value(u'db encoding', u'utf8')
-- 
https://code.launchpad.net/~rapecik/openlp/bug-941692/+merge/94702
Your team OpenLP Core is subscribed to branch lp:openlp.